Closed deepcharles closed 2 years ago
The C implementation of Pelt (KernelCPD) returned different segmentations when applied several times on the same signal (see #145).
KernelCPD
This was because in the C code, we were accessing an address outside of the memory bounds of an array (something like array[-1] instead of array[0]).
array[-1]
array[0]
I also added a test to verify that KernelCPD always returns the same result on the same signal.
The C implementation of Pelt (
KernelCPD) returned different segmentations when applied several times on the same signal (see #145).This was because in the C code, we were accessing an address outside of the memory bounds of an array (something like
array[-1]instead ofarray[0]).I also added a test to verify that
KernelCPDalways returns the same result on the same signal.