search

deepcharles / ruptures

ruptures: change point detection in Python
BSD 2-Clause "Simplified" License
1.56k stars 161 forks source link

Relax GitHub Actions first time contributor approval #235

Closed Illviljan closed 2 years ago

Illviljan commented 2 years ago

A while back GitHub made it so that new contributors cannot trigger GitHub Actions workflows and a maintainer has to hit "Approve and Run" every time they push a commit to their PR. This is rather annoying for both the contributor and the maintainer as the back and forth takes time.

This setting can be relaxed however, see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#configuring-required-approval-for-workflows-from-public-forks

oboulant commented 2 years ago

Hi @Illviljan ,

Thx for you interest in ruptures !

Nevertheless, we are quite happy with this behaviour since it allows to be parsimonious with GHA.

Best !

Illviljan commented 2 years ago

I assume maintainers will be more active in the PR section then? Considering there are PRs there needing approvals.