search

deepcharles / ruptures

ruptures: change point detection in Python
BSD 2-Clause "Simplified" License
1.56k stars 161 forks source link

docs: Ensemble dimensions #248

Closed theovincent closed 2 years ago

theovincent commented 2 years ago

This is the new version of the PR #240 with far less commits but the same content. This PR is also rebased on the master branch.

theovincent commented 2 years ago

@oboulant, @deepcharles are you happy with the example proposed here? :)

oboulant commented 2 years ago

@oboulant, @deepcharles are you happy with the example proposed here? :)

Minor comments but looks good to me 👍

deepcharles commented 2 years ago

Thanks to you both. I added some changes also (mostly about the "story" we want to tell). The diff is a bit messy because I rename the file.

Please tell me if there any typo, otherwise we are good to go.

oboulant commented 2 years ago

Thanks to you both. I added some changes also (mostly about the "story" we want to tell). The diff is a bit messy because I rename the file.

Please tell me if there any typo, otherwise we are good to go.

I made a final pass ! Good to go on my side ! Indeed, the story telling is better !

Congrats @theovincent and @deepcharles !

theovincent commented 2 years ago

I am okay with the changes.

Thank you a lot @deepcharles and @oboulant for reviewing my PR. I learnt a lot :)