Open rfayat opened 1 year ago
Hi Romain,
Thanks for you message. This would indeed be a great addition to have more metrics.
For the adjusted Rand Index, I do not mind to have scikit-learn as a dependency so your current implementation is fine by me. Do not hesite to make a pull request.
Same comment for a metric derived from the Intersection over Union.
If you make a PR, just put the code, and we'll work together from here.
Many thanks!
I should have some bandwidth to take care of it and open a PR early next week :smile:
Cheers,
Romain
Hi !
First of all thanks a lot for this great toolbox (and for the great review that comes with it).
While using
ruptures
I noticed that only a few metrics were available for comparing two segmentations and thought it would maybe be a good idea to implement additional ones.For instance, it is super straightforward to implement the adjusted randindex by leveraging the efficient implementation of the adjusted rand score in scikit learn (although adding this to
ruptures
would imply to add scikit as a dependency) :I guess there are much more similar metrics (Intersection over Union...) that could be added to
ruptures
in order to make the package even more complete than it is right now.Of course this is simply a suggestion and I would be happy to give a hand if you think this direction would indeed be interesting to pursue :)
Cheers,
Romain