Closed probberechts closed 10 months ago
@probberechts Thx for the great work ! Can you push some fake changes : indeed it is strange, your created PR did not trigger the usual automated checks (tests and everything).
This is an example of a recent PR for which I could allow the usual checks to run for a first time contributor : https://github.com/deepcharles/ruptures/pull/315
I don't know why it didn't work, but I think you should be able to run the workflows now.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
03ff932
) 98.77% compared to head (0347762
) 98.77%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
On my end : Current implementation: 17.23 seconds Adapted implementation: 1.36 seconds
🚀
This PR makes some small modifications to improve the speed of the BottomUp segmentation algorithm, especially when applied to long time series.
Below is a simple benchmark:
Current implementation: 46.08 seconds
Adapted implementation: 6.94 seconds