search

deepeshgoeliitk / bingAdsR

Bing Ads in R
Other
10 stars 5 forks source link

Needs to migrate to v13 of Bing Ads API #3

Open sshemtov opened 4 years ago

sshemtov commented 4 years ago

Hello,

The package no longer seems to work since the sunset of v12. It's now version v13 https://docs.microsoft.com/en-us/advertising/guides/migration-guide?view=bingads-13

Can you please update?

Thanks

sshemtov commented 4 years ago

I changed the endpoint to https://bingads.microsoft.com/Reporting/v13 in the reporting-.header.xml and reporting.submitGenerateReportRequest.xml but still getting this error:

Error in if (is.null(reportId) | reportId == "") { : argument is of length zero

sshemtov commented 4 years ago

^^^ error happens after executing the getReportId() function

jburkhardt commented 4 years ago

@sshemtov did you checkout https://github.com/jburkhardt/RBingAds

sshemtov commented 4 years ago

@jburkhardt have not seen it yet but I do use your RAdwords package! When I originally began using bingAdsR I saw that you never got around to finishing a Bing package due to XML complexities.

I will check out your RBingAds when I get a chance but for now I was able to patch bingAdsR by copying the code for the getReportId and getDownloadUrl functions and replacing the /v12 with /v13 in the endpoint urls - then call my new functions instead. Also, had to change the endpoint urls in the 2 XML files in the package's /data/ folder.