search

deepfakes / faceswap-playground

User dedicated repo for the faceswap project
306 stars 194 forks source link

Problems with the filter of convert #248

Closed Lancelotgogo closed 5 years ago

Lancelotgogo commented 5 years ago

Filter for convert function is not working. And I had to rewrite a few lines to make it work again. I'm sure there is something wrong in the code.

torzdf commented 5 years ago

Convert is being refactored in the not too distant future, so this will be patched then. If you wish to raise a PR to patch it in the interim, then go ahead.

bryanlyon commented 5 years ago

For now, the recommendation is to filter before convert (either at extract or with the sort tool). This will effectively work the same as the filter in convert.

Lancelotgogo commented 5 years ago

For now, the recommendation is to filter before convert (either at extract or with the sort tool). This will effectively work the same as the filter in convert.

Thank you. I will give it a try.