Remove baseDir from IsSkippableDir

[j0nnyr0berts]

• I would expect that if "{sep}var{sep}lib{sep}docker" is included in blacklisted_paths that the contents of /var/lib/docker will not be scanned
• However, when scanning docker images, baseDir = /tmp/Deepfence/SecretScanning/df_<image_name><imagetag>/ExtractedFiles which means that /var/lib/docker is not skipped
• Removing baseDir from the IsSkippableDir check also allows for matching multiple directories with one pattern
  • If this is seen as undesirable then we could always use strings.HasPrefix

Love the software and am keen to use it in CI pipelines but need to be able to effectively ignore directories to control false positives 🙂

[ramanan-ravi]

@j0nnyr0berts Thanks for your contribution.

But following use case should also be handled:

• User wants to ignore /lib but not /var/lib

Current code handles this.

Can you make this new behaviour optional based on a configuration parameter here?

[j0nnyr0berts]

@ramanan-ravi good point! How about using if strings.HasPrefix(path, skippablePathIndicator) instead?

[ramanan-ravi]

@ramanan-ravi good point! How about using if strings.HasPrefix(path, skippablePathIndicator) instead?

That works

[j0nnyr0berts]

@ramanan-ravi good point! How about using if strings.HasPrefix(path, skippablePathIndicator) instead?

That works

Updated! 🙂