deepfence / ThreatMapper

Open Source Cloud Native Application Protection Platform (CNAPP)
https://deepfence.io
Apache License 2.0
4.82k stars 584 forks source link

Private cloud - Remove nodes marked as 'Unknown' from topolgy #229

Closed sandman137 closed 2 years ago

sandman137 commented 2 years ago

Describe the bug When ThreatMapper sensors run on OpenShift or any on prem environment the typical cloud->region->computes hierarchy is not present. Due to this a lot of nodes get marked as 'Unknown'.

To Reproduce Install sensors anywhere outside public cloud to see this issue.

Expected behavior We shouldnt expect a rigid hierarchy like cloud->region->compute etc. Ideally this will be solved with ability to filter on various types of computes: E.g. show

But for existing openshift users, this has to be solved by simply not rendering any nodes and edges (esp meta nodes like cloud region) that are identified as 'Unknown' and instead expanding the children node recursively

i.e. unknown -> unknown -> node N -> processes should end up in direct expansion of node N

Screenshots

image (3)

Components/Services affected

ramanan-ravi commented 2 years ago

We will rename "Unknown" cloud node to "Private Cloud" and rename "Unknown" region node to "Zone"

sandman137 commented 2 years ago

Here is the GUI in action now image (4)