search

deepfence / ThreatMapper

Open Source Cloud Native Application Protection Platform (CNAPP)
https://deepfence.io
Apache License 2.0
4.84k stars 584 forks source link

container in Table view does not expand #297

Open jo19in1 opened 2 years ago

jo19in1 commented 2 years ago
  1. Go to table view
  2. Expand Digital Ocean-->deepfence-management-console-->deepfence-secrect-scanner
  3. It keeps expanding forever image

4.I think ideally it should have been a non-expandable line item, that only brings up a side panel when clicked, example this mongod container

image

manV commented 2 years ago

@jo19in1 a fix is in the progress for this.

ibreakthecloud commented 2 years ago

@manV please close this with PR reference if fixed.

ibreakthecloud commented 2 years ago

@manV pls. update this

manV commented 2 years ago

I have a case when this will occur, when we have expanded up to host or container level and we collapse a parent node 2 levels above. Currently we only tell server to collapse the parent node which is 2 levels above but server doesn't know that some of the children 2 levels deep were also expanded. It would still think they are expanded.

Now if we try to expand children 2 levels deep again, server thinks they are already expanded and returns nothing, so UI hangs in the loading state forever.

We can recursively tell server to collapse expanded children up-to the parent so this issue does not occur. PR is at https://github.com/deepfence/ThreatMapper/pull/636

manV commented 2 years ago

this is also related https://github.com/deepfence/ThreatMapper/pull/640