deepfence / ThreatMapper

Open Source Cloud Native Application Protection Platform (CNAPP)
https://deepfence.io
Apache License 2.0
4.8k stars 578 forks source link

acknowledgement is missing while deleting the compliace logs from the settings page #746

Open mukuldeepfence opened 1 year ago

mukuldeepfence commented 1 year ago

acknowledgement is missing while deleting the compliace logs from the settings page

To Reproduce Steps to reproduce the behavior:

  1. Go to settings page and delete the compliance / posture docs/ reports
  2. user don't see the error/success for the action

Expected behavior we should tell the user that docs has been deleted or not visually

Screenshots image

Components/Services affected

milan-deepfence commented 1 year ago

@mukuldeepfence I see successfully delete message on enterprise branch, Do you have credentials to test on kafka-rest branch, I see there is no difference in terms of code:

Screenshot 2022-12-15 at 5 48 08 PM
milan-deepfence commented 1 year ago

Got 500 internal server error on threatmapper kafka-rest branch:

curl 'https://167.71.236.9/deepfence/v1.5/docs/delete' \ -H 'authority: 167.71.236.9' \ -H 'accept: application/json, text/javascript' \ -H 'accept-language: en-GB,en-US;q=0.9,en;q=0.8' \ -H 'authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJmcmVzaCI6ZmFsc2UsImlhdCI6MTY3MTExODY0NiwianRpIjoiMDcwMzc5Y2UtM2U4Mi00MjgxLTg5MzYtMjE1OTEyNWE4YWMwIiwidHlwZSI6ImFjY2VzcyIsInN1YiI6eyJpZCI6MSwiZmlyc3RfbmFtZSI6Im0iLCJsYXN0X25hbWUiOiJtIiwiZW1haWwiOiJtQGQuaW8iLCJjb21wYW55IjoiZCIsInJvbGUiOiJhZG1pbiIsImFwaV9rZXkiOiJmZDI4ZDlhZC1kODM2LTRmZTktOGM2Yy01M2M4YjUyZjFkNDciLCJpc0FjdGl2ZSI6dHJ1ZSwiY29tcGFueV9saWNlbnNlX2V4aXN0cyI6dHJ1ZX0sImV4cCI6MTY3MTIwNTA0Nn0.Utj5iiNyuFTERC6GaPQ-7iHtVvkLwnVGp4aRwskaY1wP357TgH0YK9cxSX3eRh2w9q7OxsoT32hqkdszRSU4lP8ssbgGJVuFlEsjemtf6WRhSGBYgKS6ODNGKAcoZDlTqPAD3slNfieUA4ZSLuQch8buULh9ctI5pKsl2Oz3NkOHlVcOoBJ0i46HQ4bjfpyNr0v3eDEr83U8rdr_mBbqkziv4vu3n_kyQG-06FrVMUooBzYPmhKhaWun8xWSiJeyTZe1lims8CwaXYp11WU_CmrQHf6-V6pzZ9z26VbUwwyVY-4noOx1QZF4JIlUrYk2WekcUqode9jla1OJbpLAUA' \ -H 'content-type: application/json' \ -H 'deepfence-key: fd28d9ad-d836-4fe9-8c6c-53c8b52f1d47' \ -H 'referer: http://0.0.0.0:4042/' \ -H 'sec-ch-ua: "Not?A_Brand";v="8", "Chromium";v="108", "Google Chrome";v="108"' \ -H 'sec-ch-ua-mobile: ?0' \ -H 'sec-ch-ua-platform: "macOS"' \ -H 'sec-fetch-dest: empty' \ -H 'sec-fetch-mode: cors' \ -H 'sec-fetch-site: cross-site' \ -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36' \ -H 'x-requested-with: XMLHttpRequest' \ --data-raw '{"number":"1","doc_type":"compliance","time_unit":"day","status":"info"}' \ --compressed \ --insecure

manV commented 1 year ago

@mukuldeepfence can someone take a look from backend? Please assign accordingly.