deepflowio / deepflow

eBPF Observability - Distributed Tracing and Profiling
https://deepflow.io
Apache License 2.0
2.8k stars 308 forks source link

[FR] FR-30: tempo data has no network span #2740

Open shaohuading opened 1 year ago

shaohuading commented 1 year ago

Search before asking

DeepFlow Component

Server

What you expected to happen

火焰图中包含应用span, 系统span和网络span,而通过tempo接口,只能查询到应用span和系统span, 网络span数据是缺失的。查看deepflow-app的源码,发现是有对网络span数据的处理的。 image image image

How to reproduce

No response

DeepFlow version

deepflow-server: v6.2.5 deepflow-app:latest

DeepFlow agent list

No response

Kubernetes CNI

No response

Operation-System/Kernel version

No response

Anything else

No response

Are you willing to submit a PR?

Code of Conduct

sharang commented 1 year ago

When adapting Tempo, in order to reduce the complexity of implementation, we did not support net span at the beginning. This feature will be completed in v6.3.

duanshuaimin commented 1 month ago

Is the feature completed yet at present? thanks

sharang commented 3 weeks ago

@duanshuaimin The net-span and sys-span currently share the same span ID, and there isn’t a good way to display them without modifying Tempo. We are still considering solutions and may need to recalculate the span IDs.

Additionally, we are considering another issue: in most cases, users only need to check the sys-span and app-span. If a network issue is suspected, they can directly search for the span ID in the request-log panel to identify which network hop is causing the problem. In other words, not displaying the net-span in Tempo might make the results simpler and more readable.