search

deepgram-devs / dg-translation-chrome-ext

A TypeScript chrome extension that uses Deepgram to provide live transcription and translation
MIT License
10 stars 8 forks source link

Add logic in options.ts to handle API key submission #15

Closed BekahHW closed 2 years ago

BekahHW commented 2 years ago

Proposed changes

Right now, we're asking for the API key in popup.ts, but it would be a better user experience if we had an options page that allows the user to put in their Deepgram API key and iTranslate (eventually) at the same time.

Take a look at options.html to see the input and form information.

Move the logic out of popup.ts to options.ts

rmirville commented 2 years ago

@BekahHW What should the extension look like when this is done? Would a PR for this include adding an options button/link to popup.html and a "Save Settings" button/link on options.html that takes you back?

BekahHW commented 2 years ago

@rmirville options is a special case for chrome extensions. This blogpost has images that shows where the options will populate once added to the manifest.json file.

https://medium.com/extensions-development/chrome-extension-options-page-9428920f7309

rmirville commented 2 years ago

Okay, great. I'd like to work on this issue! Can you assign this to me?

BekahHW commented 2 years ago

Absolutely, @rmirville!