search

deepgram-devs / jamfest

0 stars 0 forks source link

Extract player plugin #5

Closed mlodato517 closed 2 years ago

mlodato517 commented 2 years ago

This Commit

Extracts some player related logic into a player plugin.

Why?

To keep the player-centric things separate from the rest of the game logic. Just to keep files smaller and help people scan things faster.

mlodato517 commented 2 years ago

how would one extract Player-SomethingElse systems?

Yeah this is a great question. I feel like:

  1. code organization "in general" is a really hard problem (maybe one of the reasons we get paid so much!)
  2. we're fairly new to bevy so maybe we should "just try something" and make a bigger game some day - increasing the scope of the game will help us run into pain points with the designs we've chosen and then we can learn what's better

But, at the current moment, I have no idea what's a good idea or not :sweat_smile:

nikolawhallon commented 2 years ago

how would one extract Player-SomethingElse systems?

Yeah this is a great question. I feel like:

1. code organization "in general" is a really hard problem (maybe one of the reasons we get paid so much!)

2. we're fairly new to `bevy` so maybe we should "just try something" and make a bigger game some day - increasing the scope of the game will help us run into pain points with the designs we've chosen and then we can learn what's better

But, at the current moment, I have no idea what's a good idea or not sweat_smile

  1. code organization has idioms and conventions in different disciplines - in OO game programming, the conventions are often clear (certainly they are in Godot, to me at least now with some experience) - I think in the ECS world, they will also become clear to us over time

  2. yeah exactly, that's why I approved this, I definitely think we should merge it, it is, indeed, "just trying something" and it seems reasonable, but let's keep the question in our mind as we go more to town