search

deepgram / deepgram-dotnet-sdk

.NET SDK for Deepgram's automated speech recognition APIs.
https://developers.deepgram.com
MIT License
33 stars 30 forks source link

HotFix for SetTimeout() having no effect #179

Closed dhymik closed 9 months ago

dhymik commented 11 months ago

This fixes #127 ("A customer reported that it's not possible to set the HTTP Timeout at all now.")

See this comment for the idea to this pull request.

Problem: deepgram.SetHttpClientTimeout(...) has no effect.

Hotfix: removed .HttpClient.Create() in HttpClientUtil.SetTimeOut(TimeSpan timeSpan)

bmaluijb commented 10 months ago

Please get this released ASAP. This bug is costing me money

davidvonthenen commented 10 months ago

As I mentioned here: https://github.com/orgs/deepgram/discussions/554

I am just coming on board to the project and will be taking a look at this today along with other .NET related stuff. From a quick glance, it looks like it isn't much of a fix but more trying to undo a mistake. We need to verify and perform due diligence before committing any changes to prevent any unintended consequences of the change. If you rollback to .NET v3.1.0 that should remove the timeout functionality and get you going again.

davidvonthenen commented 9 months ago

This PR https://github.com/deepgram/deepgram-dotnet-sdk/pull/207 has been merged and released 3.4.1.