search

deepgram / deepgram-dotnet-sdk

.NET SDK for Deepgram's automated speech recognition APIs.
https://developers.deepgram.com
MIT License
30 stars 31 forks source link

[release-v3] Temporary Fix for v3 Timeouts #207

Closed dvonthenen closed 8 months ago

dvonthenen commented 8 months ago

This supersedes this PR: https://github.com/deepgram/deepgram-dotnet-sdk/pull/179

I would have used that PR but there were Project Properties that needed to be updated beyond what was provided.

NOTE: This is going on the release-v3 branch and will tag a release from there.

Summary by CodeRabbit

Summary by CodeRabbit

dvonthenen commented 8 months ago

@coderabbitai review

coderabbitai[bot] commented 8 months ago

[!WARNING]

Rate Limit Exceeded

@dvonthenen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 7 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between e735bfa96c7d18a7a6b9773a0fefba09efb7490a and 71588bc63657c77660342c4c00b9de161edc47bc.

Walkthrough

The recent updates encompass changes to the overall Deepgram project, focusing on metadata adjustments in the Deepgram.csproj file and a bug fix in the HttpClientUtil.cs file within the Utilities namespace related to timeout settings.

Changes

File Path Change Summary
Deepgram/Deepgram.csproj Updated metadata: PackageId, Title, added Version, Authors; removed Company information.
.../Utilities/HttpClientUtil.cs Implemented a bug fix in SetTimeOut method to adjust timeout value handling in HttpClient logic.
Deepgram.Tests/UtilitiesTests/HttpClientUtilTests.cs Added namespaces: System, Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection. Added ExecuteAsync_NotExecutedWithinTimeout_ThrowsExecptionAsync method for testing timeout scenarios.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
dvonthenen commented 8 months ago

Ok. So I have done a ton of analysis on this issue. The analysis here is correct but also has a ton of other consequences: https://github.com/deepgram/deepgram-dotnet-sdk/issues/127#issuecomment-1779085524

Immediate problems - as the above analysis points out, we can't re-create the client because all of the clients have pointers to the initial httpclient created when the clients were initialized. we need to remove the creation of the client in order to set the timeout of the original clients. this also means that the timeout value is shared among all clients

things to note - a single HttpClientUtil() object is not thread-safe; consequently neither is DeepgramClient. Setting the timeout value to multiple different values in multiple threads based on need (for example, uploading a large file) might inadvertently increase the timeouts for other requests. The same is true for smaller values... you might inadvertently (like for a simple get) decrease the timeout for operations needing more time in another thread. the take away, you must have a HttpClientUtil() per thread. To be on the safest side while using timeouts, you need to consider using a timeout value that is a high watermark value for all operations in a single thread when using a single DeepgramClient.

Calling an attempting to set the timeout multiple times (ie after the first initial GET/PUT/etc), will yield in an exception:

System.InvalidOperationException : This instance has already started one or more requests. Properties can only be modified before sending the first request.

Hence the need for the high watermark value (ie time for your longest operation) if a single DeepgramClient is used in each thread.