Closed davidvonthenen closed 7 months ago
The updates focus on enhancing the configuration for the on-premise option across various client tests in the Deepgram SDK, alongside removing the KeepAlive
property and its related logic from the DeepgramHttpClientOptions
. These changes streamline the initialization of client options and adjust the HTTP client configuration, particularly for on-premise deployments, while simplifying the options model by eliminating less relevant properties.
Files | Change Summary |
---|---|
.../UnitTests/ClientTests/*.cs |
Set OnPrem to true using object initializer in client options. |
.../UnitTests/HttpExtensionsTests/HttpClientExtensionTests.cs |
Updated _clientOptions initialization by adjusting custom headers setup. |
Deepgram/Abstractions/AbstractRestClient.cs |
Removed logging of KeepAlive option. |
Deepgram/Models/Authenticate/v1/DeepgramHttpClientOptions.cs |
Removed KeepAlive property and updated constructor signature. |
Deepgram/Models/Authenticate/v1/DeepgramWsClientOptions.cs |
Updated constructor signature and modified sections. |
examples/prerecorded/file/Program.cs |
Added prompt for user to press any key to exit after displaying JSON response. |
KeepAlive
and adjustments in client option initializations align with the broader goal of refining HTTP/REST client configurations.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I have been thinking about this a lot and I think separating out HTTP vs WS is probably the better thing to do for ClientOptions. As an example, the KeepAlive (currently) has no meaning for HTTP (yes, I know HTTP does actually support keeping a connection open). Just seems like this is the best way to avoid "overloaded" meanings on this because the object is entirely different.
Other changes:
Constructor(null, null, null, null, something)
Summary by CodeRabbit
KeepAlive
property and associated logic from client options to streamline HTTP client setup.