Closed dvonthenen closed 4 months ago
[!IMPORTANT]
Auto Review Skipped
More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.
105 files out of 158 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.
You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tests pass.
This PR fixes a bunch of issues found from users and I will attempt to break it down below:
v3
) where the DG exception/error is not sent to the user. this PR introduces DG Exceptions to the ProjectDeepgram/Models/Exceptions/v1
tests/expected_failures/rest/throw_exception
Analyze
Topics so that theTopics
field in the result is populated (was missing the{ get; set; }
)ToString()
function inModels
to override a class struct dump in favor of a dump everything to JSON. I grew tired of serializing objects to JSON.ToString()
which means just doing something likeConsole.Writeline("Dump: {object}");
since objects can now be written/converted to a string.PrerecordSchema
->PreRecordSchema
should match the naming convention ofPreRecorded
this is the reason why you see a bunch ofDeepgram.Tests
changes. I would just ignore anything starting withDeepgram.Tests
for changes.Yea, this looks like a lot. The majority of changes are ToString and display related things. The code changes of importance is really:
Tested examples:
tests/expected_failures/rest/throw_exception