search

deepgram / deepgram-dotnet-sdk

.NET SDK for Deepgram's automated speech recognition APIs.
https://developers.deepgram.com
MIT License
33 stars 31 forks source link

Fix `net6` Dependencies for Projects #281

Closed davidvonthenen closed 7 months ago

davidvonthenen commented 7 months ago

Addresses issue: https://github.com/deepgram/deepgram-dotnet-sdk/issues/280

This should fix both Deepgram (the SDK) and Deepgram.Microphone projects in the repo.

Not exactly sure how this PR changed the dependencies, but looks like I missed it. https://github.com/deepgram/deepgram-dotnet-sdk/commit/d19ac8f3e6307ac56e5504be7c6cafeba7528d34

Summary by CodeRabbit

coderabbitai[bot] commented 7 months ago

Walkthrough

The recent updates involve adjusting package versions and adding specific configurations for different .NET target frameworks in the Deepgram.Microphone and Deepgram projects. These changes also include the integration of Microsoft.CodeAnalysis.NetAnalyzers to enhance code analysis across various frameworks.

Changes

File Path Change Summary
Deepgram.Microphone/...csproj Updated PackageReference versions for net6.0, net7.0, net8.0; added Microsoft.CodeAnalysis.NetAnalyzers.
Deepgram/Deepgram.csproj Adjusted PackageReference versions and conditions for multiple packages across different .NET target frameworks.

Possibly related issues

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 461f841e9dfff2cfd7895af6d55ea684157be816 and 7f098d1b2c92d905deaee6500238d02db80043f0.
Files selected for processing (2) * Deepgram.Microphone/Deepgram.Microphone.csproj (4 hunks) * Deepgram/Deepgram.csproj (4 hunks)
Additional Context Used
Learnings (2)
Deepgram.Microphone/Deepgram.Microphone.csproj (1)
``` User: dvonthenen PR: deepgram/deepgram-dotnet-sdk#253 File: Deepgram.Dev.sln:0-0 Timestamp: 2024-03-28T19:45:21.188Z Learning: References to "Prerecorded" and other project names in the documentation and build scripts have been updated as part of the PR changes. Remaining mentions of "Prerecorded" in `Deepgram/README.md`, `examples/README.md`, and `README.md` were noted for potential review. ```
Deepgram/Deepgram.csproj (1)
``` User: dvonthenen PR: deepgram/deepgram-dotnet-sdk#253 File: Deepgram.Dev.sln:0-0 Timestamp: 2024-03-28T19:45:21.188Z Learning: References to "Prerecorded" and other project names in the documentation and build scripts have been updated as part of the PR changes. Remaining mentions of "Prerecorded" in `Deepgram/README.md`, `examples/README.md`, and `README.md` were noted for potential review. ```
Additional comments not posted (4)
Deepgram.Microphone/Deepgram.Microphone.csproj (2)
`83-106`: > :memo: **NOTE** > This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [71-96] Review the inclusion of Microsoft.CodeAnalysis.NetAnalyzers and other package references for different target frameworks. Verify that the versions of the packages like `Microsoft.CodeAnalysis.NetAnalyzers`, `Microsoft.Extensions.DependencyInjection.Abstractions`, and others are compatible with each target framework. This is crucial to avoid runtime issues due to incompatible library versions. --- `83-106`: > :memo: **NOTE** > This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [100-117] Check compatibility of package versions with net7.0 and net8.0 frameworks. Ensure that the package versions specified for `net7.0` and `net8.0`, especially new packages like `Microsoft.CodeAnalysis.NetAnalyzers`, are fully compatible with these frameworks. This is important as using incompatible versions can lead to build or runtime errors.
Deepgram/Deepgram.csproj (2)
`83-106`: > :memo: **NOTE** > This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [71-96] Review the inclusion of Microsoft.CodeAnalysis.NetAnalyzers and other package references for different target frameworks. Verify that the versions of the packages like `Microsoft.CodeAnalysis.NetAnalyzers`, `Microsoft.Extensions.DependencyInjection.Abstractions`, and others are compatible with each target framework. This is crucial to avoid runtime issues due to incompatible library versions. --- `83-106`: > :memo: **NOTE** > This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [100-117] Check compatibility of package versions with net7.0 and net8.0 frameworks. Ensure that the package versions specified for `net7.0` and `net8.0`, especially new packages like `Microsoft.CodeAnalysis.NetAnalyzers`, are fully compatible with these frameworks. This is important as using incompatible versions can lead to build or runtime errors.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
davidvonthenen commented 7 months ago

@coderabbitai review

jpvajda commented 7 months ago

Tests pass on this. 👍

davidvonthenen commented 7 months ago

Verified references are good. Screenshot 2024-04-24 at 09 48 04