This is hopefully the last fix for the reconnect logic. We found a couple of things that were preventing the reconnect. Most importantly, we ditched the attempt to reuse the context object. It just flat out wasn't working well. Because we now need to provide a context object on reconnect, it breaks the interface for the live client, but thankful the impact should only be in one place in the user's code.
What types of changes does your code introduce to the community Go SDK?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update or tests (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Proposed changes
This is hopefully the last fix for the reconnect logic. We found a couple of things that were preventing the reconnect. Most importantly, we ditched the attempt to reuse the context object. It just flat out wasn't working well. Because we now need to provide a context object on reconnect, it breaks the interface for the live client, but thankful the impact should only be in one place in the user's code.
Have a couple of examples to demonstrate client reuse and misc functionality (please also see https://github.com/deepgram/deepgram-go-sdk/pull/231).
Types of changes
What types of changes does your code introduce to the community Go SDK? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA