Closed dvonthenen closed 2 months ago
[!IMPORTANT]
Review skipped
Review was skipped due to path filters
Files ignored due to path filters (48)
* `examples/manage/balances/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/manage/invitations-new-RENAME/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/manage/invitations/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/manage/keys/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/manage/members/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/manage/projects/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/manage/scopes/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/manage/usage/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/callback/callback/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/callback/endpoint/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/file-new-RENAME/Bueller-Life-moves-pretty-fast.mp3` is excluded by `!**/*.mp3`, `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/file-new-RENAME/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/file/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/intent/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/sentiment/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/stream/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/summary/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/topic/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/rest/url/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/websocket/http/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/websocket/microphone-new-RENAME/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/websocket/microphone/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/websocket/replay/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/speech-to-text/websocket/test/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/rest/file-new-RENAME/hello-world/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/rest/file/hello-world/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/rest/file/woodchuck/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/rest/stream/hello-world/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/rest/stream/woodchuck/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/rest/writer/hello-world/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/rest/writer/woodchuck/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/websocket/interactive/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `examples/text-to-speech/websocket/simple/main.go` is excluded by `!examples/**`, `!!tests/expected_failures/**` * `pkg/api/speak/v1/websocket/default.go` is excluded by `!!tests/expected_failures/**` * `pkg/api/speak/v1/websocket/interfaces/constants.go` is excluded by `!!tests/expected_failures/**` * `pkg/api/speak/v1/websocket/interfaces/interfaces.go` is excluded by `!!tests/expected_failures/**` * `pkg/api/speak/v1/websocket/interfaces/types.go` is excluded by `!!tests/expected_failures/**` * `pkg/api/speak/v1/websocket/router.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/common/v1/common.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/interfaces/utils.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/interfaces/v1/utils.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/listen/client.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/listen/v1/websocket/client.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/listen/v1/websocket/constants.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/speak/client.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/speak/v1/rest/client.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/speak/v1/websocket/client.go` is excluded by `!!tests/expected_failures/**` * `pkg/client/speak/v1/websocket/constants.go` is excluded by `!!tests/expected_failures/**`You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent updates to the Deepgram Go SDK involve various import path changes, package refactoring, function deprecations, and updates to logging and error handling. Key modifications include reorganizing client packages for better consistency, adding recovery mechanisms for panic situations, adjusting SDK versioning, and refining the instantiation processes across different API interfaces including manage
, listen
, speak
, and websocket
.
Files/Directories | Change Summary |
---|---|
examples/manage/* |
Updated import paths from rest to manage in all main.go files. |
examples/speech-to-text/rest/* |
Switched API package from prerecorded/v1 to listen/v1/rest . |
examples/speech-to-text/websocket/* |
Changed imports from live/v1/interfaces to listen/v1/websocket/interfaces and updated client instantiation. |
examples/text-to-speech/rest/* |
Updated import path from speak/v1 to speak/v1/rest and modified client instantiation processes. |
examples/text-to-speech/rest/writer/* |
Updated import paths and client instantiation in hello-world and woodchuck modules. |
examples/text-to-speech/websocket/* |
Refactored text input sending process for better readability in interactive and simple modules. |
pkg/client/speak/v1/websocket/* |
Updated log messages and function names for clarity and consistency. |
pkg/client/interfaces/v1/utils.go |
Updated SDK version constant from "v1.2.0" to "v1.4.0". |
pkg/client/listen/client.go |
Added and deprecated aliases for listenv1rest.Client and listenv1ws.Client to streamline client usage. |
pkg/client/listen/v1/websocket/* |
Added deferred recovery functions to handle panics in Client struct methods. |
pkg/client/speak/client.go |
Added deprecation notice for NewWithDefaults function and introduced NewRESTWithDefaults . |
pkg/client/listen/v1/websocket/constants.go |
Introduced error constant ErrFatalPanicRecovered for handling fatal panics. |
pkg/client/speak/v1/websocket/constants.go |
Introduced error constant ErrFatalPanicRecovered for handling fatal panics. |
The changes do not include specific new features or modifications to the control flow that would necessitate sequence diagrams for better understanding. The updates largely revolve around refactoring and error-handling improvements without altering the primary interactions between components in a manner that significantly changes the overall behavior or architecture.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Proposed changes
Addresses: https://github.com/deepgram/deepgram-go-sdk/issues/251
This PR does three things:
//lint:ignore
comment. We are no longer using deprecated package names.Tested on all examples.
Types of changes
What types of changes does your code introduce to the community Go SDK? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA
Summary by CodeRabbit
New Features
listen/v1/rest
andlisten/v1/websocket
API packages.Improvements
speak
andlisten
clients.v1.4.0
.Deprecations
Refactor