search

deepgram / deepgram-js-sdk

Official JavaScript SDK for Deepgram's automated speech recognition APIs.
https://developers.deepgram.com
MIT License
127 stars 45 forks source link

feat: remove mimetype requirement from batch requests (rfc #4) #177

Closed lukeocodes closed 8 months ago

codecov-commenter commented 8 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (alpha@e7ea664). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## alpha #177 +/- ## ======================================== Coverage ? 70.40% ======================================== Files ? 16 Lines ? 517 Branches ? 100 ======================================== Hits ? 364 Misses ? 127 Partials ? 26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lukeocodes commented 8 months ago

TL:DR; yes, the API only requires a mimetype of application/json. the rest of the time, we parse the rawdata against our own tech (avoiding specifics on a public comment)

I should have linked to the RFC!

https://github.com/deepgram/deepgram-sdk-architecture/issues/4

This is an easy change, simplifies the interface, and matches the functionality of the API. But it is a breaking change, so it is a good idea to do it now while V3 (and the other SDKs major versions) are still alpha and pre-alpha.