CI: fail on test errors

deepgram / deepgram-js-sdk

Official JavaScript SDK for Deepgram's automated speech recognition APIs.

https://developers.deepgram.com

MIT License

127 stars 45 forks source link

Open longzheng opened 1 week ago

longzheng commented 1 week ago

While debugging another issue I noticed that there is actually a test failing but the CI is reporting all good. For example the last CI run https://github.com/deepgram/deepgram-js-sdk/actions/runs/9403306912/job/25899538297#step:4:120

I saw it's because the CI is only running the npm run test:coverage which doesn't seem to throw an error if there are test errors.

I thought the easiest fix is to just run the test separately to generating the coverage.

longzheng commented 1 week ago

I'm not 100% sure if the test command also needs a change since currently it has || :, which I'm not sure what the original intent was.