deepgram / deepgram-js-sdk

Official JavaScript SDK for Deepgram's automated speech recognition APIs.
https://developers.deepgram.com
MIT License
159 stars 54 forks source link

CI: fail on test errors #302

Closed longzheng closed 4 months ago

longzheng commented 5 months ago

While debugging another issue I noticed that there is actually a test failing but the CI is reporting all good. For example the last CI run https://github.com/deepgram/deepgram-js-sdk/actions/runs/9403306912/job/25899538297#step:4:120

I saw it's because the CI is only running the npm run test:coverage which doesn't seem to throw an error if there are test errors.

I thought the easiest fix is to just run the test separately to generating the coverage.

longzheng commented 5 months ago

I'm not 100% sure if the test command also needs a change since currently it has || :, which I'm not sure what the original intent was.

https://github.com/deepgram/deepgram-js-sdk/blob/7ce44bdd639891b06bfde6385a815372a5122eee/package.json#L48

lukeocodes commented 4 months ago

This should be resolved in the latest version