Moves self._socket check in __init__ up right as not to overwrite setting values
Clean exit and consolidate using def signal_exit(self):
Tested with examples/streaming and also while receiving a timeout.
Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update or tests (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
This removes any unhandled exceptions from making it to the user... preserves the exception through an option in case someone is using that as a means of doing something higher up.
Proposed changes
This should address issue https://github.com/deepgram/deepgram-python-sdk/pull/305
Changes include:
self._socket
check in__init__
up right as not to overwrite setting valuesdef signal_exit(self):
Tested with
examples/streaming
and also while receiving a timeout.Types of changes
What types of changes does your code introduce to the community Python SDK? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA