Implement Open/Close Events with Additional Exception Handling

dvonthenen commented 6 months ago

Proposed changes

Addresses issues: https://github.com/deepgram/deepgram-python-sdk/issues/333, https://github.com/deepgram/deepgram-python-sdk/issues/329, https://github.com/deepgram/deepgram-python-sdk/issues/308

Notable changes:

Adds a new OpenResponse and CloseResponse events.
All 4 examples updated to print when those events are emitted.
Async client has additional exception handling. Noticed we aren't keeping track of threads which could throw an exception if one of the threads get hung up.
Async streaming examples updated to make sure termination or shutdown is done correctly without exception. you can now hit cntl + c to exit async examples.

Updated the examples/streaming for Async and Threaded. Those work as expected. Tested all examples including the exception examples.

Types of changes

What types of changes does your code introduce to the community Python SDK? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have lint'ed all of my code using repo standards
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

NA

ghbaud commented 6 months ago

Happy to help with the testing. Tell me what to do.

dvonthenen commented 6 months ago

Happy to help with the testing. Tell me what to do.

You can uninstall the deepgram-sdk you have in your package manager and then checkout out this repo and PR on disk, then do a pip install -e . as a developer.

ghbaud commented 6 months ago

See my reply on discord

On Wed, Mar 6, 2024 at 9:10 PM David vonThenen @.***> wrote:

Happy to help with the testing. Tell me what to do.

You can uninstall the deepgram-sdk you have in your package manager and then checkout out this repo and PR on disk, then do a pip install -e . as a developer.

— Reply to this email directly, view it on GitHub https://github.com/deepgram/deepgram-python-sdk/pull/334#issuecomment-1982209218, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRKYFACXX4ZHQTEUJZI5T3YW7EA7AVCNFSM6AAAAABEJ6O3T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGIYDSMRRHA . You are receiving this because you commented.Message ID: @.***>

deepgram / deepgram-python-sdk