The LiveClient has been far more stable than the AsyncLiveClient. This makes both clients similar in flow by shifting the AsyncLiveClient to behave similarly to the LiveClient. The AsyncClient uses a more traditional recv() process for the listening thread which allows us know control paths and when certain signals are set. I simply could not get the initial refactoring of the AsyncClient first done in the v3 architecture mainly due to exception handling.
Changes:
Fixed send() to return True/False. Every other language uses bytes returns except for Python. I totally forgot about this. This shouldn't be a big deal since no one was using the return type anyways.
Added exception handling in send() so we don't need to have exception handling everywhere else. Since send() is either successful or not via exception. Just log it. If there is an error, the overall connection will throw an exception in one of the threads.
A couple more None checks to explicitly state is not None in certain areas
Updated all examples to really hammer the clients this time around. Take a look at tests/edge_cases, which repeatedly connects/disconnects and reuses a single client in a loop without issue.
Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update or tests (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Proposed changes
The LiveClient has been far more stable than the AsyncLiveClient. This makes both clients similar in flow by shifting the AsyncLiveClient to behave similarly to the LiveClient. The AsyncClient uses a more traditional
recv()process for the listening thread which allows us know control paths and when certain signals are set. I simply could not get the initial refactoring of the AsyncClient first done in the v3 architecture mainly due to exception handling.Changes:
send()to return True/False. Every other language uses bytes returns except for Python. I totally forgot about this. This shouldn't be a big deal since no one was using the return type anyways.send()so we don't need to have exception handling everywhere else. Sincesend()is either successful or not via exception. Just log it. If there is an error, the overall connection will throw an exception in one of the threads.Nonechecks to explicitly stateis not Nonein certain areasUpdated all examples to really hammer the clients this time around. Take a look at
tests/edge_cases, which repeatedly connects/disconnects and reuses a single client in a loop without issue.Types of changes
What types of changes does your code introduce to the community Python SDK? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA