deepgram / deepgram-python-sdk

Official Python SDK for Deepgram's automated speech recognition APIs.
https://developers.deepgram.com
MIT License
178 stars 48 forks source link

Implement Unhandled Events #357

Closed dvonthenen closed 2 months ago

dvonthenen commented 2 months ago

Proposed changes

This implements an unhandled event type. If there is a new event type encountered that the SDK currently doesn't implement, this will fire off a "unhandled' event type and just return the raw JSON to the user through this event. The idea is that the user can take this raw JSON and handle the event themselves until the event is supported in the SDK.

This is already implemented in the Go SDK: https://github.com/deepgram/deepgram-go-sdk/blob/main/pkg/api/live/v1/interfaces/interfaces.go#L18

Also a slight addition for this PR that was submitted by a member in the community that was just merged: https://github.com/deepgram/deepgram-python-sdk/pull/355

For the fix above, the emit close event needs to be before triggering the disconnect on the set() function. Otherwise, the event will not fire.

Types of changes

What types of changes does your code introduce to the community Python SDK? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments