Closed jkroll-deepgram closed 2 months ago
I do also see in other spots that events are being initialized as asyncio.Event(). Should the exit event be instantiated as self._exit_event = asyncio.Event() instead of self._exit_event = None, so self._exit_event is never None in the first place?
I can take a look at this and double check.
I suspect that the event should have been reset and not deleted is the problem. This might have been a copy and paste gone too far. Confirming this now.
Proposed changes
Fix a bug where
is_set()
is being called onself._exit_event
when it has a value ofNone
, causing anAttributeError
that bubbles up as an error in application code. To fix, require thatself._exit_event is not None
before callingself._exit_event.is_set()
.I do also see in other spots that events are being initialized as
asyncio.Event()
. Should the exit event be instantiated asself._exit_event = asyncio.Event()
instead ofself._exit_event = None
, soself._exit_event
is neverNone
in the first place?Types of changes
What types of changes does your code introduce to the community Python SDK? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments