I believe this is similar to this issue fixed in PR https://github.com/deepgram/deepgram-python-sdk/pull/366. The threads should have already exited (because of the join and gather) but in the event that hasn't happened yet, this keeps the thread references around until a reconnect has happened (ie they will be replaced with new thread references).
Also, found in testing an additional place where an exception can be thrown on a successful exit.
Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update or tests (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Proposed changes
Addresses issue: https://github.com/deepgram/deepgram-python-sdk/issues/370
I believe this is similar to this issue fixed in PR https://github.com/deepgram/deepgram-python-sdk/pull/366. The threads should have already exited (because of the
joinandgather) but in the event that hasn't happened yet, this keeps the thread references around until a reconnect has happened (ie they will be replaced with new thread references).Also, found in testing an additional place where an exception can be thrown on a successful exit.
Types of changes
What types of changes does your code introduce to the community Python SDK? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Tested AsyncLive and Live Clients for all examples.