I started by having DeepgramHttpClientOptions and DeepgramWsClientOptions, but having the deepgram.live or deepgram.manage|prerecorded|etc complicates things a lot. Ideally, I would rather ditch the dot notation for a more explicit and separate HTTP and WS ClientOptions, but here we are.
I want to break this in the next iteration (ie v4 of the SDK), but until then... we have this PR.
Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update or tests (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Proposed changes
Addresses: https://github.com/deepgram/deepgram-python-sdk/issues/360
I started by having DeepgramHttpClientOptions and DeepgramWsClientOptions, but having the
deepgram.liveordeepgram.manage|prerecorded|etccomplicates things a lot. Ideally, I would rather ditch the dot notation for a more explicit and separate HTTP and WS ClientOptions, but here we are.I want to break this in the next iteration (ie
v4of the SDK), but until then... we have this PR.Types of changes
What types of changes does your code introduce to the community Python SDK? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA