search

deepgram / deepgram-python-sdk

Official Python SDK for Deepgram's automated speech recognition APIs.
https://developers.deepgram.com
MIT License
175 stars 47 forks source link

Have Explicit and Distinct `DeepgramHttpClientOptions` and `DeepgramWsClientOptions` #379

Open dvonthenen opened 2 months ago

dvonthenen commented 2 months ago

Proposed changes

Currently, all WebSockets and HTTP(s) options are combined into a single ClientOptions class. You run into situations when options like KeepAlive, which are used for WebSockets, are needed. You can enable KeepAlive on HTTP(s) clients like ManageClient, but they literally have no function or meaning.

The more the WS and HTTP(s) options grow, the more this object will have options that mean something for one transport type but will have no meaning in the other.

This requires implementing or should I say removing this issue: https://github.com/deepgram/deepgram-python-sdk/issues/378

Context

Possible Implementation

Other information