deepgram / kur

Descriptive Deep Learning
Apache License 2.0
814 stars 107 forks source link

a tiny error in character_rnn example kurfile #29

Closed EmbraceLife closed 7 years ago

EmbraceLife commented 7 years ago

Hi @noajshu , Thanks for your character example, it is great!

@ajsyp has pointed to me something is not exactly right with the weights, and now I realized the tiny issue there. Inside kurfile.yaml, is the following weights what you wanted, instead of here:

train:
  data:
    - jsonl: ../data/train.jsonl
  epochs: 5
  weights:
    initial: best.w.kur
    best: best.w.kur
    last: last.w.kur
  log: log

validate:
  data:
    - jsonl: ../data/validate.jsonl
  weights: best.w.kur

test:
  data:
    - jsonl: ../data/test.jsonl
  weights: best.w.kur
ajsyp commented 7 years ago

My recommendation is to do the following:

If you feel up to it, go ahead and submit a pull request for this!