search

deepgram / kur

Descriptive Deep Learning
Apache License 2.0
814 stars 107 forks source link

Add min_duration option to speechrec supplier. #30

Closed antho-rousseau closed 7 years ago

antho-rousseau commented 7 years ago

Added an option to provide a minimum duration for speech examples, just like the maximum duration one.

ajsyp commented 7 years ago

This looks great @antho-rousseau! One request before we merge it in: a couple of your edited lines are indented with spaces; we use tabs in Kur, so do you mind replace "4 spaces" with "1 tab", and then we'll pull it in?

antho-rousseau commented 7 years ago

@ajsyp no problem, should be good to go now!

ajsyp commented 7 years ago

It looks like line 429, part of the SpeechRecognitionSupplier.__init__ signature still has spaces preceding it:

                max_frequency=None, vocab=None, samples=None, *args, **kwargs):
antho-rousseau commented 7 years ago

Oh yes, right, didn't saw this one! Thanks, should be good this time!

ajsyp commented 7 years ago

Awesome, looks great, thanks!