search

deepgram / kur

Descriptive Deep Learning
Apache License 2.0
816 stars 107 forks source link

Propose a new feature to animate layers #77

Open EmbraceLife opened 7 years ago

EmbraceLife commented 7 years ago

I have made an animate feature to work. Should I make a PR for this? If so, how can I make a second PR while the first one is not accepted yet? Thanks

ajsyp commented 7 years ago

That looks pretty cool! Does it work by loading pre-saved files from the plot_weights hook? If this works for all layer types in Kur, then it could make sense for it to be part of Kur using the animate sub-command like you showed. On the other hand, if it only works for a certain set of models / layers, then it makes a lot of sense for it to be a plugin (I'll try to find some time to document the plugin features, so you have a template for how to write these).