search

deepgram / self-hosted-resources

Official Deepgram resources for deploying Deepgram services in a self-hosted environment
https://developers.deepgram.com
ISC License
6 stars 4 forks source link

[ISSUE-27] Fix EFS Storage Class Mismatch with Name Prefix #28

Closed paulliwog closed 1 month ago

paulliwog commented 1 month ago

This change fixes a template issue when using AWS EFS as the storage for self-hosted deployments

paulliwog commented 1 month ago

LGTM! This shouldn't affect functionality, but it does keep consistent naming across Deepgram resources.

Could you add a line to the CHANGELOG.md under a new header called "Unreleased" describing the change in the specified format there?

I'll get that added. This was impacting functionality in our cluster as we are using Karpenter Autoscaler; the name mismatch prevented karpenter from scheduling the engine pod, so it wouldn't spin up a new node for it.

bd-g commented 1 month ago

That's good to know! This hasn't been explicitly tested with Karpenter, so I wasn't aware of that. Thanks for the heads up!

In that case, if you have autoscaling enabled to include the HPA manifests, make sure to explicitly disable the cluster-autoscaler dependency.

bd-g commented 1 month ago

Thank you! I'll cut a release for this later today.

Thanks for your patience on the Changelog request. The other open PR in this report will include a few more CI checks to help guide PR submissions to include that 😀