deephacks / lmdbjni

LMDB for Java
Apache License 2.0
204 stars 28 forks source link

Improve transaction pattern #24

Closed phraktle closed 9 years ago

phraktle commented 9 years ago

Try-with-resources is a nicer idiom. Fixes issue #23.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 94.26% when pulling 33503385decad8a62b92f972ee5171675104417b on phraktle:phrak-tx-closeable into 3400a43865d27d31b698cdd6f3c8376d1478e37c on deephacks:master.

phraktle commented 9 years ago

The abort on close is actually a no-op, if a commit was performed previously (since self is zero).

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 94.26% when pulling beba00c81e8ba6485329584e6a9f315019176de3 on phraktle:phrak-tx-closeable into 3400a43865d27d31b698cdd6f3c8376d1478e37c on deephacks:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 94.26% when pulling 90c159a4d89b9b784c36fff580fc7ddcc86a3af7 on phraktle:phrak-tx-closeable into 3400a43865d27d31b698cdd6f3c8376d1478e37c on deephacks:master.