search

deephacks / lmdbjni

LMDB for Java
Apache License 2.0
204 stars 28 forks source link

linux32 #69

Closed jayenashar closed 7 years ago

jayenashar commented 8 years ago

couldn't figure out how to detect 32-bit on travis didn't see a need to change jmh couldn't get ByteArrayComparator working

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 87.542% when pulling f7f060d711252d1a2570128a2aeae200bfce1b60 on jayenashar:master into 14b264abebb43bd918aa4cbf5e81ceb777f336a3 on deephacks:master.

krisskross commented 8 years ago

I'm not sure I want to take this PR. Releasing and supporting 32-bit artifacts would be a hassle.

I'm open to support 32-bit it if we can automate the procedure through travis but I don't have time to spend on this now. But please take a stab if you want.

jayenashar commented 8 years ago

I'd love to take a stab at Travis, but haven't got the time right now either. Would you be open to adding a mention in your readme?

krisskross commented 8 years ago

Not sure what you want mentioned? Issue #63 is about automating maven releases. We could add a comment on linux32 also?

jayenashar commented 8 years ago

If you're open to adding a mention, then I would worry about what to mention. Probably if I push the linux32 to maven, you could add a maven block for it? I would probably only push 0.4.6 and not earlier versions. If you have a different suggestion for people to use linux32 without building from source, I'm open to it, but I think what I mention above is relatively easy for all parties involved.

Thanks for the link to #63. If I get time to learn how to configure/use Travis, I'll have a look at that one as well.