deephaven / benchmark

Deephaven Benchmarking
Apache License 2.0
0 stars 3 forks source link

Wrong Wildcard Expansion in Distro Tar Runner #370

Closed stanbrub closed 1 month ago

stanbrub commented 1 month ago

The distribution tar that is included as an asset in the Github release if 0.33.4 contains a script called benchmark.sh, which is used to run tests. One of the examples given in the script's comments is benchmark.sh 1 *. This is meant as a wildcard to be passed to the test runner but expands to a file list. Quoting the wildcard like benchmark,.sh 1 "*" is no help.

Investigation shows that the passing of the variable to a called process $(echo "${TEST_WILD"} is the culprit. Quoting doesn't work.