search

deephaven / deephaven-core

Deephaven Community Core
Other
255 stars 80 forks source link

RspBitmap.minus Should Avoid Unconditional Deepcopy #3550

Open cpwright opened 1 year ago

cpwright commented 1 year ago

As a user, I want the minus operation to only allocate elements as necessary rather than copying the implementation and then subtracting from the copy. In some cases (e.g. ShiftDataExpander) the two indices may have substantial overlap and we could avoid the allocations except for the differences.

jcferretti commented 1 year ago

Some additional context from Charles: https://github.com/deephaven-ent/iris/commit/ed5e2455231f1f0a83eafa59214ed65f120caab4