search

deephaven / deephaven-core

Deephaven Community Core
Other
251 stars 80 forks source link

SortedClockFilter assumes Flattening #4092

Open cpwright opened 1 year ago

cpwright commented 1 year ago

Description

The SortedClockFilter wants flat tables: https://github.com/deephaven/deephaven-core/blob/46cea1223744765dabc2ba02dd04ca6873cc5dba/engine/table/src/main/java/io/deephaven/engine/table/impl/select/SortedClockFilter.java#L54

But we just sort the input table here: https://github.com/deephaven/deephaven-core/blob/46cea1223744765dabc2ba02dd04ca6873cc5dba/engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java#L1126

In some cases, sort might return a non-flat table (e.g. if it happened to be already sorted).

This results in an error when you try to actually use your SortedClockFilter.

cpwright commented 1 year ago

Code from https://deephaven.atlassian.net/browse/DH-15146 may be useful when this becomes relevant.