search

deephaven / deephaven-core

Deephaven Community Core
Other
255 stars 81 forks source link

Error in gradle configuration when building #4271

Open mofojed opened 1 year ago

mofojed commented 1 year ago

Description

:web:jar does not declare it's dependencies correctly, resulting in a warning (and sometimes an error) in the gradle logs.

> Task :web:jar FAILED
Execution optimizations have been disabled for task ':web:jar' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/home/bender/dev/deephaven/iris-oss/core/main/web/client-ui/build/dhide'. Reason: Task ':web:jar' uses this output of task ':web-client-ui:uiSync' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
  - Gradle detected a problem with the following location: '/home/bender/dev/deephaven/iris-oss/core/main/proto/raw-js-openapi/build/dhapi'. Reason: Task ':web:jar' uses this output of task ':proto:raw-js-openapi:webpackSourcesSync' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
  - Gradle detected a problem with the following location: '/home/bender/dev/deephaven/iris-oss/core/main/proto/proto-backplane-grpc/build/generated/source/proto/main/js'. Reason: Task ':web:jar' uses this output of task ':proto:proto-backplane-grpc:generateProtobufSync' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.

> Task :engine-table:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':web:jar'.
> Could not list contents of '/home/bender/dev/deephaven/iris-oss/core/main/web/client-ui/build/dhide/ide/assets/index-b4ca870a.js'.

Steps to reproduce

  1. Run ./gradlew :web:jar

Expected results

  1. No warnings or errors

Actual results

  1. Get warnings about Execution Optimizations being disabled, and occasionally get an error: 
    > Task :web:jar
Execution optimizations have been disabled for task ':web:jar' to ensure correctness due to the following reasons:
- Gradle detected a problem with the following location: '/home/bender/dev/deephaven/iris-oss/core/main/web/client-ui/build/dhide'. Reason: Task ':web:jar' uses this output of task ':web-client-ui:uiSync' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
- Gradle detected a problem with the following location: '/home/bender/dev/deephaven/iris-oss/core/main/proto/raw-js-openapi/build/dhapi'. Reason: Task ':web:jar' uses this output of task ':proto:raw-js-openapi:webpackSourcesSync' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
- Gradle detected a problem with the following location: '/home/bender/dev/deephaven/iris-oss/core/main/proto/proto-backplane-grpc/build/generated/source/proto/main/js'. Reason: Task ':web:jar' uses this output of task ':proto:proto-backplane-grpc:generateProtobufSync' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
devinrsmith commented 1 year ago

This may be something we need to solve anyways more generally before upgrading to gradle 8, https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#task_and_transform_validation_warnings_introduced_in_gradle_7_x_are_now_errors. https://github.com/deephaven/deephaven-core/issues/4131

I believe Colin and I have both taken light stabs at upgrading to gradle 8 - I don't think it's a huge lift, but just something that will take some more dedicated time.