search

deephaven / deephaven-core

Deephaven Community Core
Other
236 stars 79 forks source link

Patch releases of jsapi-types getting dist-tag `latest` incorrectly #5572

Open mofojed opened 1 month ago

mofojed commented 1 month ago

Description

When we publish a patch version of deephaven-core (and subsequently a patch version of the @deephaven/jsapi-types package), it should not be labelled as latest. For example, we previously published v0.34.3, which is the latest version. We then went back and released a patch to v0.33, and published v0.33.4. That should not have the dist-tag of latest, latest should still point to v0.34.3. For web-client-ui packages, we set the dist tag to just the major version number of the release branch that is being patched, e.g. https://github.com/deephaven/web-client-ui/blob/37571633dd0be5b7a606bee45af10f6a7d09d4ec/lerna.json#L6

See screenshot below. v0.34.3 was published 13 days ago, and then we published a patch 0.33.4 yesterday, but that stole the latest tag.

Additional details and attachments image

mofojed commented 1 month ago

Fix would just be changing latest to the release branch name at https://github.com/deephaven/deephaven-core/blob/bf13489d48327e2e3d504e6be13020f30c46bd23/.github/workflows/publish-ci.yml#L120 (e.g. v0.33)