search

deephaven / deephaven-core

Deephaven Community Core
Other
255 stars 80 forks source link

`dependency released by user` error is at too high of logging level #5835

Open jnumainville opened 3 months ago

jnumainville commented 3 months ago

Description

Sometimes when code is reran such as in certain deephaven.ui cases, an error is surfaced.

p1241897134-65 | i.d.s.s.SessionState | Internal Error '573fef7b-bf05-4464-9a13-46e595d293b5' dependency released by user. This error does not actually break anything, but it makes it seem like something is broken.

It seems like this error should be at a lower logging level so it is not surfaced to the user as an error.

Some additional info in https://github.com/deephaven/deephaven-plugins/issues/456 and DH-17415

Steps to reproduce

from deephaven.plot import express as dx
from deephaven import ui

stocks = dx.data.stocks()

@ui.component
def ui_plot():
    return dx.line(stocks, x="timestamp", y="price")

# just running this line again induces the error
result = ui_plot()

Expected results

No error.

Actual results

The error. Nothing is actually broken (you can continue to run code just fine), but the error message makes it seem like something is wrong or the user made a mistake.

Versions Engine Version: 0.35.0 Web UI Version: 0.83.0 Java Version: 19.0.1 Barrage Version: 0.6.0 Browser Name: Chrome 126 OS Name: macOS 10.15.7 @deephaven/js-plugin-plotly-express: 0.11.0 @deephaven/js-plugin-ui: 0.18.0

rcaudy commented 3 months ago

We need to determine if this is useful enough in debugging situations to keep it at the current log level, or if we should drop it to avoid annoying users for false-positives.