deephaven / deephaven-core

Deephaven Community Core
Other
257 stars 80 forks source link

Iceberg java keyword column name handling #6119

Open devinrsmith opened 1 month ago

devinrsmith commented 1 month ago

Deephaven does not currently handle Iceberg column names that happen to be java keywords.

For example, the Iceberg column name "long" will result in a TableDefinition column name of "column_long". In this scenario though, the data is no longer properly mapped.

https://gist.github.com/devinrsmith/86b4f5fa827509df458834e7ba07ad08

Screenshot from 2024-09-24 12-13-28

devinrsmith commented 1 month ago

A test skeleton has been sketched out for this in io.deephaven.iceberg.PyIceberg1Test#cities2