fix: Correct rollup and tree snapshot code to wait for missed structural dependencies

deephaven / deephaven-core

Deephaven Community Core

Other

257 stars 80 forks source link

fix: Correct rollup and tree snapshot code to wait for missed structural dependencies #6395

Closed rcaudy closed 1 day ago

rcaudy commented 2 days ago

Fixes #6394

rcaudy commented 2 days ago

Ad-hoc testing with several variations of the reproducer from the issue suggests that this fix resolves the problem. Nightlies passed. Will work on one or more unit tests.

rcaudy commented 1 day ago

Correct RollupTableImpl.maybeWaitForStructuralSatisfaction(): we were mistakenly not waiting for the root
Correct TreeTableImpl.maybeWaitForStructuralSatisfaction(): we were mistakenly not waiting for the sourceRowLookup in unfiltered cases
Rename QueryTableTreeTest to TestHierarchicalTableSnapshots, and add tests for structural satisfaction fixes
Fix resource leak in HierarchicalTableImpl, address unnecessary copyPrev() usage, and address a spurious warning about lossy auto-increment