deephaven / deephaven-plugins

Deephaven Plugins
5 stars 12 forks source link

Remove row/column index from dh.ui mouse handlers #528

Closed mattrunyon closed 1 week ago

mattrunyon commented 1 month ago

The mouse handlers like on_row_press currently provide the row index to the server. This is quite dangerous to actually use because it's based on the client view of the table. So if a user sorts a table in the web UI, the row index will not match the same row that the UI component has on its server table.

We should remove row/column index from all mouse handlers since they are not a reliable way to get more data from the table for the selected row/column.

We could use #513 and provide the always fetched column data with the row data even on cell press so that there could be a user defined key column that is passed to always_fetch_columns.