deephaven / deephaven-plugins

Deephaven Plugins
5 stars 12 forks source link

fix: Wrap the children of ReactPanel with an ErrorBoundary #565

Closed mofojed closed 2 weeks ago

mofojed commented 2 weeks ago
mofojed commented 2 weeks ago

This will need to be picked back to ui-v0.15 as well

mattrunyon commented 2 weeks ago

How do you reproduce this? Is there an example or would I need to add JS code to throw?

mofojed commented 2 weeks ago

@mattrunyon I tested against Enterprise with bender_DH-16737 (against dev-grizzly), using steps described in my comments: https://github.com/deephaven-ent/iris/pull/1822#issuecomment-2179377442 Also created a dashboard with a table in it and tested that. I've added steps to this PR description on how to test it with Core. I had a branch with debug commands to help test that.