deephaven / deephaven-plugins

Deephaven Plugins
6 stars 14 forks source link

`DeephavenColor` and `StaticColor` types are incorrect #600

Closed mofojed closed 6 days ago

mofojed commented 1 month ago

DeephavenColor only has salmon and lemonchiffon: https://github.com/deephaven/deephaven-plugins/blob/1623ff53a3e5119b76da5f6bf9ef407334a2f985/plugins/ui/src/deephaven/ui/types/types.py#L224 That type should have all the values defined in our colorUtils: https://github.com/deephaven/web-client-ui/blob/a11e2ceaf216d640068562a05fdb156c69481d47/packages/components/src/theme/colorUtils.ts#L6 Also StaticColor is used in many spots where Color should be used instead - StaticColor should only be used for static_color props.