Closed AkshatJawne closed 2 months ago
@mofojed Right, that makes sense. From my perspective, this change mainly does two things:
Adds the "compact" density by default, which @dsmmcken and @mattrunyon agreed looks better -- https://github.com/deephaven/deephaven-plugins/pull/489#issuecomment-2204501724
Adds the styling to the tabs component, such that if a user wanted to wrap the tabs component in a ui.view
, they could have it display correctly, assuming that they have a height
and width
set, as I showed in the snippet above.
However, if the idea is that we want to discourage users from wrapping tabs in a ui.view, I agree, the scss is definitely not needed. May still want the density = "compact"
though, @dsmmcken can confirm.
I would change just compact density, other changes seems unnecessary now.
I would add some "size-100" to the tablist margin bottom by default though.
Unsure how the new tab component works, if it is a python wrapper of the tab_list, if so I would add that as a default on tab_list in python rather than JS, so it's surfaced to users as a default
Should be good now, had to set to 8px instead of size-100, given that the marginBottom on the python side expects a DimensionValue
.
Should be good now, had to set to 8px instead of size-100, given that the marginBottom on the python side expects a DimensionValue.
That's wrong. DimensionValue accepts a string. "size-100" should work correctly. Don't hardcode with pixel values.
Need @dsmmcken 's approval to merge
Resolves #360 and resolves #476 (and also the request for a seperate styling PR made here: https://github.com/deephaven/deephaven-plugins/pull/489#issuecomment-2206860382)
Also, with regards to the snippet, as mentioned in Matt's comment, to have this properly working, we will need to have a height and width set on the view itself:
So to have the snippet work, it would have to be something like the following: