deephaven / deephaven-plugins

Deephaven Plugins
11 stars 15 forks source link

ui.table quick_filters do not update when values are changed #709

Open mofojed opened 3 months ago

mofojed commented 3 months ago

Description

When the props passed to quick_filters changes, the ui.table does not update to reflect it.

Steps to reproduce

  1. Create the following component:
    
    from deephaven import ui
    from deephaven.plot import express

_stocks = dx.data.stocks()

@ui.component def my_table(source, column="Sym"): value, set_value = ui.use_state("FISH")

return [
    ui.text_field(value=value, on_change=set_value),
    ui.table(source, quick_filters={column: value})
]

mt = my_table(_stocks, "Sym")


2. In the text field in the component that appears, change "FISH" to "DOG"

**Expected results**
2. Quick filter should update, Sym should now be filtered on DOG

**Actual results**
2. Table does not update

**Additional details and attachments**
![image](https://github.com/user-attachments/assets/5b231022-9461-431a-8b62-e70f5c4c06c4)

**Versions**
Engine Version: 0.35.2
Web UI Version: 0.85.3
Java Version: 11.0.23
Barrage Version: 0.6.0
Browser Name: Chrome 126
OS Name: Linux
deephaven-plugin-ptt-input: 0.0.1
@deephaven/js-plugin-plotly-express: 0.11.2
@deephaven/js-plugin-ui: 0.19.0
mattrunyon commented 3 months ago

I believe this was intentional to not clobber any client-side user changes